[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829371#action_12829371
]
Carl Steinbach commented on HIVE-1123:
--------------------------------------
I reverted the indentation changes and modified the Checkstyle configuration in
order
to disable indentation checks. I did not revert the switch statement changes
since I don't
have an automatic way of doing this nor a canonical list of where I made those
changes.
I also maintain that switch statement braces should be avoided unless you
really need
to define a new scope, in which case you probably shouldn't be using a switch
statement
in the first place.
Zheng, please take a look. Thanks.
> Checkstyle fixes
> ----------------
>
> Key: HIVE-1123
> URL: https://issues.apache.org/jira/browse/HIVE-1123
> Project: Hadoop Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1123.checkstyle.patch, HIVE-1123.cli.2.patch,
> HIVE-1123.cli.patch, HIVE-1123.common.2.patch, HIVE-1123.common.patch,
> HIVE-1123.contrib.2.patch, HIVE-1123.contrib.patch, HIVE-1123.hwi.2.patch,
> HIVE-1123.hwi.patch, HIVE-1123.jdbc.2.patch, HIVE-1123.jdbc.patch,
> HIVE-1123.metastore.2.patch, HIVE-1123.metastore.patch, HIVE-1123.ql.2.patch,
> HIVE-1123.ql.patch, HIVE-1123.serde.2.patch, HIVE-1123.serde.patch,
> HIVE-1123.service.2.patch, HIVE-1123.service.patch, HIVE-1123.shims.2.patch,
> HIVE-1123.shims.patch
>
>
> Fix checkstyle errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
