[ 
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829379#action_12829379
 ] 

Carl Steinbach commented on HIVE-1123:
--------------------------------------

I favor doing this:

{code:java}
int i;
switch(n) {
case 0:
  i = 3;
case 1:
  i = 2;
  System.out.println(i);
}
{code}

I believe that I have only removed braces in those cases where
the local scope is not necessary. There are a variety of places in
the code where the local scope *is* required, or where the switch
statements are nested. In these cases I have not removed the braces.


> Checkstyle fixes
> ----------------
>
>                 Key: HIVE-1123
>                 URL: https://issues.apache.org/jira/browse/HIVE-1123
>             Project: Hadoop Hive
>          Issue Type: Task
>            Reporter: Carl Steinbach
>            Assignee: Carl Steinbach
>         Attachments: HIVE-1123.checkstyle.patch, HIVE-1123.cli.2.patch, 
> HIVE-1123.cli.patch, HIVE-1123.common.2.patch, HIVE-1123.common.patch, 
> HIVE-1123.contrib.2.patch, HIVE-1123.contrib.patch, HIVE-1123.hwi.2.patch, 
> HIVE-1123.hwi.patch, HIVE-1123.jdbc.2.patch, HIVE-1123.jdbc.patch, 
> HIVE-1123.metastore.2.patch, HIVE-1123.metastore.patch, HIVE-1123.ql.2.patch, 
> HIVE-1123.ql.patch, HIVE-1123.serde.2.patch, HIVE-1123.serde.patch, 
> HIVE-1123.service.2.patch, HIVE-1123.service.patch, HIVE-1123.shims.2.patch, 
> HIVE-1123.shims.patch
>
>
> Fix checkstyle errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to