[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830019#action_12830019
]
Carl Steinbach commented on HIVE-1123:
--------------------------------------
bq. I talked with a bunch of team members. We will wait till Friday noon for
feedbacks and decide what to do with these patches then.
Sounds good!
bq. By the way, Carl, is it easy to configure eclipse NOT to produce
checkstyle-alarming code? As far as I know, eclipse leaves spaces in blank
lines.
You can configure Eclipse to automatically remove trailing whitespace on save
by going to
Properties -> Java Editor -> Save Actions. I think it should be possible to to
add this to
the project settings so that folks will have it automatically set when they
import the
project into Eclipse. I will look into getting this setup, along with other
formatting settings
that are compatible with the Checkstyle configuration.
> Checkstyle fixes
> ----------------
>
> Key: HIVE-1123
> URL: https://issues.apache.org/jira/browse/HIVE-1123
> Project: Hadoop Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1123.checkstyle.patch, HIVE-1123.cli.2.patch,
> HIVE-1123.cli.patch, HIVE-1123.common.2.patch, HIVE-1123.common.patch,
> HIVE-1123.contrib.2.patch, HIVE-1123.contrib.patch, HIVE-1123.hwi.2.patch,
> HIVE-1123.hwi.patch, HIVE-1123.jdbc.2.patch, HIVE-1123.jdbc.patch,
> HIVE-1123.metastore.2.patch, HIVE-1123.metastore.patch, HIVE-1123.ql.2.patch,
> HIVE-1123.ql.patch, HIVE-1123.serde.2.patch, HIVE-1123.serde.patch,
> HIVE-1123.service.2.patch, HIVE-1123.service.patch, HIVE-1123.shims.2.patch,
> HIVE-1123.shims.patch
>
>
> Fix checkstyle errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
