[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829829#action_12829829
]
Carl Steinbach commented on HIVE-1123:
--------------------------------------
The following checks are common to the Hive checkstyle configuration and the
default Sun checks configuration:
*
[ArrayTypeStyle|http://checkstyle.sourceforge.net/config_misc.html#ArrayTypeStyle]
*
[AvoidNestedBlocks|http://checkstyle.sourceforge.net/config_blocks.html#AvoidNestedBlocks]
*
[AvoidStarImport|http://checkstyle.sourceforge.net/config_imports.html#AvoidStarImport]
*
[ConstantName|http://checkstyle.sourceforge.net/config_naming.html#ConstantName]
* [EmptyBlock|http://checkstyle.sourceforge.net/config_blocks.html#EmptyBlock]
*
[EmptyForIteratorPad|http://checkstyle.sourceforge.net/config_whitespace.html#EmptyForIteratorPad]
*
[EmptyStatement|http://checkstyle.sourceforge.net/config_coding.html#EmptyStatement]
*
[EqualsHashCode|http://checkstyle.sourceforge.net/config_coding.html#EqualsHashCode]
* [FileLength|http://checkstyle.sourceforge.net/config_sizes.html#FileLength]
*
[FileTabCharacter|http://checkstyle.sourceforge.net/config_whitespace.html#FileTabCharacter]
* [FinalClass|http://checkstyle.sourceforge.net/config_design.html#FinalClass]
* [HiddenField|http://checkstyle.sourceforge.net/config_coding.html#HiddenField]
*
[HideUtilityClassConstructor|http://checkstyle.sourceforge.net/config_design.html#HideUtilityClassConstructor]
*
[InnerAssignment|http://checkstyle.sourceforge.net/config_coding.html#InnerAssignment]
*
[JavadocPackage|http://checkstyle.sourceforge.net/config_javadoc.html#JavadocPackage]
*
[JavadocStyle|http://checkstyle.sourceforge.net/config_javadoc.html#JavadocStyle]
*
[JavadocType|http://checkstyle.sourceforge.net/config_javadoc.html#JavadocType]
** Only required for public types. Allow missing parameter tags.
* [LeftCurly|http://checkstyle.sourceforge.net/config_blocks.html#LeftCurly]
* [LineLength|http://checkstyle.sourceforge.net/config_sizes.html#LineLength]
** Increased to 100 characters.
*
[LocalFinalVariableName|http://checkstyle.sourceforge.net/config_naming.html#LocalFinalVariableName]
*
[LocalVariableName|http://checkstyle.sourceforge.net/config_naming.html#LocalVariableName]
* [MemberName|http://checkstyle.sourceforge.net/config_naming.html#MemberName]
*
[MethodLength|http://checkstyle.sourceforge.net/config_sizes.html#MethodLength]
* [MethodName|http://checkstyle.sourceforge.net/config_naming.html#MethodName]
*
[MethodParamPad|http://checkstyle.sourceforge.net/config_whitespace.html#MethodParamPad]
*
[MissingSwitchDefault|http://checkstyle.sourceforge.net/config_coding.html#MissingSwitchDefault]
*
[ModifierOrder|http://checkstyle.sourceforge.net/config_modifier.html#ModifierOrder]
* [NeedBraces|http://checkstyle.sourceforge.net/config_blocks.html#NeedBraces]
*
[NewlineAtEndOfFile|http://checkstyle.sourceforge.net/config_misc.html#NewlineAtEndOfFile]
*
[NoWhitespaceAfter|http://checkstyle.sourceforge.net/config_whitespace.html#NoWhitespaceAfter]
*
[NoWhitespaceBefore|http://checkstyle.sourceforge.net/config_whitespace.html#NoWhitespaceBefore]
* [PackageName|http://checkstyle.sourceforge.net/config_naming.html#PackageName]
*
[ParameterName|http://checkstyle.sourceforge.net/config_naming.html#ParameterName]
*
[ParameterNumber|http://checkstyle.sourceforge.net/config_sizes.html#ParameterNumber]
* [ParenPad|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
*
[RedundantModifer|http://checkstyle.sourceforge.net/config_modifier.html#RedundantModifier]
*
[RedundantThrows|http://checkstyle.sourceforge.net/config_coding.html#RedundantThrows]
* [RightCurly|http://checkstyle.sourceforge.net/config_blocks.html#RightCurly]
*
[SimplifyBooleanExpression|http://checkstyle.sourceforge.net/config_coding.html#SimplifyBooleanExpression]
*
[SimplifyBooleanReturn|http://checkstyle.sourceforge.net/config_coding.html#SimplifyBooleanReturn]
*
[StaticVariableName|http://checkstyle.sourceforge.net/config_naming.html#StaticVariableName]
* [TodoComment|http://checkstyle.sourceforge.net/config_misc.html#TodoComment]
* [TypeName|http://checkstyle.sourceforge.net/config_naming.html#TypeName]
*
[TypecastParenPad|http://checkstyle.sourceforge.net/config_whitespace.html#TypecastParenPad]
*
[UnusedImports|http://checkstyle.sourceforge.net/config_imports.html#UnusedImports]
*
[VisbilityModifier|http://checkstyle.sourceforge.net/config_design.html#VisibilityModifier]
*
[WhitespaceAfter|http://checkstyle.sourceforge.net/config_whitespace.html#WhitespaceAfter]
The following checks are present in the default Sun configuration but were
removed from the configuration that Hadoop uses (which I used as a starting
point for the Hive configuration):
*
[AvoidInlineConditionals|http://checkstyle.sourceforge.net/config_coding.html#AvoidInlineConditionals]
*
[DesignForExtension|http://checkstyle.sourceforge.net/config_design.html#DesignForExtension]
*
[FinalParameters|http://checkstyle.sourceforge.net/config_misc.html#FinalParameters]
*
[GenericWhitespace|http://checkstyle.sourceforge.net/config_whitespace.html#GenericWhitespace]
*
[JavadocMethod|http://checkstyle.sourceforge.net/config_javadoc.html#JavadocMethod]
*
[JavadocVariable|http://checkstyle.sourceforge.net/config_javadoc.html#JavadocVariable]
* [MagicNumber|http://checkstyle.sourceforge.net/config_coding.html#MagicNumber]
*
[OperatorWrap|http://checkstyle.sourceforge.net/config_whitespace.html#OperatorWrap]
*
[WhitespaceAround|http://checkstyle.sourceforge.net/config_whitespace.html#WhitespaceAround]
I added the following checks to the Hive configuration:
*
[EqualsAvoidNull|http://checkstyle.sourceforge.net/config_coding.html#EqualsAvoidNull]
* [Header|http://checkstyle.sourceforge.net/config_header.html#Header]
** Checks for ASF license header.
*
[MissingOverride|http://checkstyle.sourceforge.net/config_annotation.html#MissingOverride]
*
[StringLiteralEquality|http://checkstyle.sourceforge.net/config_coding.html#StringLiteralEquality]
> Checkstyle fixes
> ----------------
>
> Key: HIVE-1123
> URL: https://issues.apache.org/jira/browse/HIVE-1123
> Project: Hadoop Hive
> Issue Type: Task
> Reporter: Carl Steinbach
> Assignee: Carl Steinbach
> Attachments: HIVE-1123.checkstyle.patch, HIVE-1123.cli.2.patch,
> HIVE-1123.cli.patch, HIVE-1123.common.2.patch, HIVE-1123.common.patch,
> HIVE-1123.contrib.2.patch, HIVE-1123.contrib.patch, HIVE-1123.hwi.2.patch,
> HIVE-1123.hwi.patch, HIVE-1123.jdbc.2.patch, HIVE-1123.jdbc.patch,
> HIVE-1123.metastore.2.patch, HIVE-1123.metastore.patch, HIVE-1123.ql.2.patch,
> HIVE-1123.ql.patch, HIVE-1123.serde.2.patch, HIVE-1123.serde.patch,
> HIVE-1123.service.2.patch, HIVE-1123.service.patch, HIVE-1123.shims.2.patch,
> HIVE-1123.shims.patch
>
>
> Fix checkstyle errors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
