Am Mon, 9 Mar 2009 04:36:27 +0000 schrieb [email protected]: > > > Remove extra info from H2Core::Note (including get_position(), ADSR, and > filter params) > > Note had a lot of information in it that probably didn't belong there. > A note should simply be pitch, velocity, duration. However, this > implementation has the Note loaded down with it's pattern position > (which is redundant -- the pattern tracks the notes position), ADSR > parameters (this should be managed by the sampler/synth... not on a > per-note basis), and parameters for a low pass resonant filter (again, > this belongs in the sample/synth). Pan L/R was left in because the > pattern editor supports them. > > Some of these parameters could be used to make a really complex type > of sampler/synth... but they're not currently supported by any > editors, song files, or sampler... and they bog down H2Core::Note, > which should be as lightweight as possible. > Commit from user: Gabriel Beddingfield
hiho, if you remove so much of this note and instrument stuff the most of note_off funktion from the fx_and sample_fun branch will broke up or the implementation needs a lot of rewrite. also the current mute group function (trunk) use the single note adsr and instrument adsr implementation. i am not sure, but if this transport will be a base for newer or h2 >0.9.4 versions it would be cool if this implementation don't need a rewrite for this well working stuff. also more than 50% from fx_and sample_fun features don't work without that. maybe it's ok. and maybe nobody is interested to implement the really useful features from this branch. but if yes, we can not implement a lot of things without a lot of work. and until 8.4.2009 my free time will dramatically reduced. we will get a little daughter in april :-))))))) hooray. so for me, it's can be a problem to do all the work for an implementation to the new transport base. but of course this is only my personal more or less small position here. so i can only say, it would be cool if we can implement the features from this branch in further versions of h2 without so many work or rewrite. wolke ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Hydrogen-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
