[email protected] wrote:
> also more than 50% from fx_and sample_fun features don't work without that.
> maybe it's
> ok. and maybe nobody is interested to implement the really useful features
> from this branch. but if yes, we
OK, I build the fx fun branch today. Nice stuff! I especially like the sample
editor.
Here's a rundown on how I think merging will go:
1. Most of the stuff in the GUI will require minor refactoring to get it
working. To get it working "right" will require only minor changes. When I
took nPosition out of Note... the DrumPatternEditor gave me the most trouble...
but it was manageable.
2. #1 includes the sample editor.
3. I plan to have full support for MIDI In and Out on the transport_redesign
branch. I doubt much of the current code would be salvaged... but (if all goes
the way I imagine it) it will not be difficult to replace, either.
4. Destructive recording will be the most interesting to merge. Right now, all
of the realtime record code is in Hydrogen::addRealtimeNote()... which is kind
of a hack to begin with. In the transport_redesign... it will look something
like this pseudo-code:
class RealtimeRecording : public SeqClientInterface
{
public:
int process(SeqScriptConstIterator& beg,
SeqScriptConstIterator& end,
const TransportPosition& pos,
uint32_t nframes)
{
SeqScriptConstIterator k;
Pattern* pat = Hydrogen::get_song()->get_pattern(pos);
for( k = beg ; k != end ; ++k ) {
// Manipulate the pattern based on the SeqEvent's
// (*k) is H2Core::SeqEvent
// It's possible that some of the addRealtimeNote stuff
// could be modified to work here.
}
}
}; // class RealtimeRecording
Anyway... I would, of course, help with the merge. :-)
Peace,
Gabriel
------------------------------------------------------------------------------
_______________________________________________
Hydrogen-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
