1. I've never been on a project with code and design reviews where they didn't
help.
2. It helps if they build tools to make it easier to adhere to the standards.
3. In the absence of common sense and good judgement, there will be problems
regardless of the rules.
The issue that I always had with code reviews was convincing my boss not to
trust me, but to take the time to critically read my work. If I make a mistake,
I'd rather find out before it causes problems.
--
Shmuel (Seymour J.) Metz
http://mason.gmu.edu/~smetz3
________________________________________
From: IBM Mainframe Discussion List [[email protected]] on behalf of Bob
Bridges [[email protected]]
Sent: Friday, June 18, 2021 12:20 PM
To: [email protected]
Subject: Re: Coding for the future
It sounds like a great idea in theory. In practice...
Ok, to be fair, I've been at only one company that implemented it, so my "in
practice" really means "at that one company". There, we worked together to
decide on a good set of coding standards. In the case of most of those
standards, we all agreed "but there are exceptional circumstances where it
should be done this way instead".
You can see where I'm headed with this: In the reviews ever after, no one
ever admitted that any exceptions were to be allowed. It seemed to me that
a lot of programming was done the hard way, as a result.
I still think peer reviews sound like a great idea, if it can be put into
practice without falling prey to a bureaucratic mindset.
---
Bob Bridges, [email protected], cell 336 382-7313
/* A good programmer is someone who looks both ways before crossing a
one-way street. -Doug Linder */
-----Original Message-----
From: IBM Mainframe Discussion List <[email protected]> On Behalf Of
Jesse 1 Robinson
Sent: Wednesday, June 16, 2021 13:45
Can't say I ever participated, but I've heard the strategy of writing only
comments, then gathering a group of folks in a room to review the 'code'.
Participants don't need to know the underlying language, or any language for
that matter. It sounds exciting.
----------------------------------------------------------------------
For IBM-MAIN subscribe / signoff / archive access instructions,
send email to [email protected] with the message: INFO IBM-MAIN
----------------------------------------------------------------------
For IBM-MAIN subscribe / signoff / archive access instructions,
send email to [email protected] with the message: INFO IBM-MAIN
