If the blitter is not available, we cannot use it as a source for dirty
rectangles. We shall have to rely on the other engines to create GPU
dirty instead.

v2: Try using lots of subgroup+fixtures

Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
---
 tests/kms_frontbuffer_tracking.c | 58 ++++++++++++++++++++++++++++++--
 1 file changed, 56 insertions(+), 2 deletions(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 8754cc461..64f253f00 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -3160,6 +3160,9 @@ static void basic_subtest(const struct test_mode *t)
        fb1 = params->primary.fb;
 
        for (r = 0, method = 0; method < IGT_DRAW_METHOD_COUNT; method++, r++) {
+               if (method == IGT_DRAW_BLT && !  gem_has_blitter(drm.fd))
+                       continue;
+
                if (r == pattern->n_rects) {
                        params->primary.fb = (params->primary.fb == fb1) ? &fb2 
: fb1;
 
@@ -3380,10 +3383,11 @@ static const char *flip_str(enum flip_type flip)
                        continue;                                          \
                if (!opt.show_hidden && t.fbs == FBS_SHARED &&             \
                    (t.plane == PLANE_CUR || t.plane == PLANE_SPR))        \
-                       continue;
+                       continue;                                          \
+               igt_subtest_group {
 
 
-#define TEST_MODE_ITER_END } } } } } }
+#define TEST_MODE_ITER_END } } } } } } }
 
 int main(int argc, char *argv[])
 {
@@ -3431,6 +3435,10 @@ int main(int argc, char *argv[])
        }
 
        TEST_MODE_ITER_BEGIN(t)
+               igt_fixture {
+                       if (t.method == IGT_DRAW_BLT)
+                               gem_require_blitter(drm.fd);
+               }
                igt_subtest_f("%s-%s-%s-%s-%s-draw-%s",
                              feature_str(t.feature),
                              pipes_str(t.pipes),
@@ -3447,6 +3455,11 @@ int main(int argc, char *argv[])
                    (!opt.show_hidden && t.method != IGT_DRAW_BLT))
                        continue;
 
+               igt_fixture {
+                       if (t.method == IGT_DRAW_BLT)
+                               gem_require_blitter(drm.fd);
+               }
+
                for (t.flip = 0; t.flip < FLIP_COUNT; t.flip++)
                        igt_subtest_f("%s-%s-%s-%s-%sflip-%s",
                                      feature_str(t.feature),
@@ -3465,6 +3478,11 @@ int main(int argc, char *argv[])
                    (t.feature & FEATURE_FBC) == 0)
                        continue;
 
+               igt_fixture {
+                       if (t.method == IGT_DRAW_BLT)
+                               gem_require_blitter(drm.fd);
+               }
+
                igt_subtest_f("%s-%s-%s-fliptrack",
                              feature_str(t.feature),
                              pipes_str(t.pipes),
@@ -3478,6 +3496,11 @@ int main(int argc, char *argv[])
                    t.plane == PLANE_PRI)
                        continue;
 
+               igt_fixture {
+                       if (t.method == IGT_DRAW_BLT)
+                               gem_require_blitter(drm.fd);
+               }
+
                igt_subtest_f("%s-%s-%s-%s-%s-move",
                              feature_str(t.feature),
                              pipes_str(t.pipes),
@@ -3501,6 +3524,11 @@ int main(int argc, char *argv[])
                    t.plane != PLANE_SPR)
                        continue;
 
+               igt_fixture {
+                       if (t.method == IGT_DRAW_BLT)
+                               gem_require_blitter(drm.fd);
+               }
+
                igt_subtest_f("%s-%s-%s-%s-%s-fullscreen",
                              feature_str(t.feature),
                              pipes_str(t.pipes),
@@ -3517,6 +3545,11 @@ int main(int argc, char *argv[])
                    (!opt.show_hidden && t.fbs != FBS_INDIVIDUAL))
                        continue;
 
+               igt_fixture {
+                       if (t.method == IGT_DRAW_BLT)
+                               gem_require_blitter(drm.fd);
+               }
+
                igt_subtest_f("%s-%s-%s-%s-multidraw",
                              feature_str(t.feature),
                              pipes_str(t.pipes),
@@ -3533,6 +3566,11 @@ int main(int argc, char *argv[])
                    t.method != IGT_DRAW_MMAP_GTT)
                        continue;
 
+               igt_fixture {
+                       if (t.method == IGT_DRAW_BLT)
+                               gem_require_blitter(drm.fd);
+               }
+
                igt_subtest_f("%s-farfromfence", feature_str(t.feature))
                        farfromfence_subtest(&t);
        TEST_MODE_ITER_END
@@ -3544,6 +3582,11 @@ int main(int argc, char *argv[])
                    t.fbs != FBS_INDIVIDUAL)
                        continue;
 
+               igt_fixture {
+                       if (t.method == IGT_DRAW_BLT)
+                               gem_require_blitter(drm.fd);
+               }
+
                for (t.format = 0; t.format < FORMAT_COUNT; t.format++) {
                        /* Skip what we already tested. */
                        if (t.format == FORMAT_DEFAULT)
@@ -3563,6 +3606,12 @@ int main(int argc, char *argv[])
                    t.plane != PLANE_PRI ||
                    t.method != IGT_DRAW_BLT)
                        continue;
+
+               igt_fixture {
+                       if (t.method == IGT_DRAW_BLT)
+                               gem_require_blitter(drm.fd);
+               }
+
                igt_subtest_f("%s-%s-scaledprimary",
                              feature_str(t.feature),
                              fbs_str(t.fbs))
@@ -3577,6 +3626,11 @@ int main(int argc, char *argv[])
                    t.method != IGT_DRAW_BLT)
                        continue;
 
+               igt_fixture {
+                       if (t.method == IGT_DRAW_BLT)
+                               gem_require_blitter(drm.fd);
+               }
+
                igt_subtest_f("%s-modesetfrombusy", feature_str(t.feature))
                        modesetfrombusy_subtest(&t);
 
-- 
2.17.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to