On Mon, Nov 25, 2013 at 09:47:28AM +0100, Daniel Vetter wrote: > On Thu, Nov 21, 2013 at 11:20:58PM +0000, Chris Wilson wrote: > > On Thu, Nov 21, 2013 at 09:29:53PM +0200, [email protected] > > wrote: > > > From: Ville Syrjälä <[email protected]> > > > > > > Flush the caches when moving a scanout buffer from CPU to GTT domain. > > > This allows us to move a scanout buffer to CPU write domain, do some > > > writes, and move it back to the GTT read domain. The display will then > > > see the correct data. In addition we still need to do the dirtyfb > > > ioctl to nuke FBC if that's enabled. > > > > > > Signed-off-by: Ville Syrjälä <[email protected]> > > Reviewed-by: Chris Wilson <[email protected]> > > Isn't this what sw_finish is for?
I was more concerned about making sure the code was reasonably self-consistent in applying our own coherency rules. As you point out, it may be userspace making a mistake, but so many paths can end up here, and almost never have pin_display, that it would seem to be preferrable to do the extra flush rather than have the discrepancy. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
