On Fri, Oct 17, 2025 at 10:32:02AM +0530, Ankit Nautiyal wrote: > Currently the guardband is optimized only for platforms where the > VRR timing generator is always ON. > > Extend the usage of optimized guardband to other platforms only when the > VRR is enabled. > > Signed-off-by: Ankit Nautiyal <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_vrr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c > b/drivers/gpu/drm/i915/display/intel_vrr.c > index cd7bed358984..eb5aa0d7fc49 100644 > --- a/drivers/gpu/drm/i915/display/intel_vrr.c > +++ b/drivers/gpu/drm/i915/display/intel_vrr.c > @@ -483,7 +483,7 @@ static bool intel_vrr_use_optimized_guardband(const > struct intel_crtc_state *crt > if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) > return false; > > - return intel_vrr_always_use_vrr_tg(display); > + return intel_vrr_always_use_vrr_tg(display) || crtc_state->vrr.enable;
I was going to say this is fine, and I guess it kinda is because intel_pipe_config_compare() will allow fastsets with a change in guardband on !intel_vrr_always_use_vrr_tg() platforms. But I don't think there's any real reason to compute the guardband differently between vrr.enable==true vs. vrr.enable==false. So I'm thinking we should just 'return true' unconditionally here. > } > > void intel_vrr_compute_guardband(struct intel_crtc_state *crtc_state) > -- > 2.45.2 -- Ville Syrjälä Intel
