> Subject: [PATCH 1/2] drm/i915/psr: Simplify the conditions for SCL computation > > 'needs_sel_update' is common for both display version branches, so check it > once and keep the version specific checks as separate early returns. > > v2: Split into separate early returns. (Jani) > > Signed-off-by: Ankit Nautiyal <[email protected]>
LGTM, Reviewed-by: Suraj Kandpal <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_psr.c | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c > b/drivers/gpu/drm/i915/display/intel_psr.c > index 546ce9846865..f6cd88902be9 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -1477,15 +1477,18 @@ int _intel_psr_min_set_context_latency(const > struct intel_crtc_state *crtc_state > * SRD_STATUS is used by PSR1 and Panel Replay DP on LunarLake. > */ > > - if (DISPLAY_VER(display) >= 30 && (needs_panel_replay || > - needs_sel_update)) > + if (needs_sel_update) > return 0; > - else if (DISPLAY_VER(display) < 30 && (needs_sel_update || > - intel_crtc_has_type(crtc_state, > - > INTEL_OUTPUT_EDP))) > + > + if (DISPLAY_VER(display) < 30 && > + intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP)) > return 0; > - else > - return 1; > + > + if (DISPLAY_VER(display) >= 30 && > + needs_panel_replay) > + return 0; > + > + return 1; > } > > static bool _wake_lines_fit_into_vblank(const struct intel_crtc_state > *crtc_state, > -- > 2.45.2
