Re: [PATCH 1/2] drm/i915/dp: s/intel_dp_needs_vsc_sdp/intel_dp_needs_vsc_colorimetry

Wed, 22 Jul 2026 04:51:38 -0700 



On 7/16/2026 11:03 AM, Samala, Pranay wrote:

Hi Chaitanya,


-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of
Chaitanya Kumar Borah
Sent: Thursday, July 9, 2026 5:10 PM
To: [email protected]; [email protected]
Cc: Borah, Chaitanya Kumar <[email protected]>
Subject: [PATCH 1/2] drm/i915/dp:
s/intel_dp_needs_vsc_sdp/intel_dp_needs_vsc_colorimetry

The function answers whether a VSC SDP with colorimetry payload is
required by the content being displayed. Rename it to reflect that.



Since this helper also controls VSC signaling for YCbCr420 pixel encoding,
it would be better to update commit message to indicate that it covers both 
cases.

Apart from this, changes LGTM.
Reviewed-by: Pranay Samala <[email protected]>



pushed to drm-intel-next with commit message change. Thank you for the 
review.





No functional change intended.

Assisted-by: GitHub_Copilot:claude-sonnet-4.6
Signed-off-by: Chaitanya Kumar Borah <[email protected]>
---
  drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/display/intel_dp.c  | 8 ++++----
drivers/gpu/drm/i915/display/intel_dp.h  | 4 ++--
  3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
b/drivers/gpu/drm/i915/display/intel_ddi.c
index 2b7eb010511b..c764472bd69a 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -470,7 +470,7 @@ void intel_ddi_set_dp_msa(const struct
intel_crtc_state *crtc_state,
         * YCBCR 420, HDR BT.2020 signals we should program MSA MISC1
fields
         * which indicate VSC SDP for the Pixel Encoding/Colorimetry Format.
         */
-       if (intel_dp_needs_vsc_sdp(crtc_state, conn_state))
+       if (intel_dp_needs_vsc_colorimetry(crtc_state, conn_state))
                temp |= DP_MSA_MISC_COLOR_VSC_SDP;

        intel_de_write(display, TRANS_MSA_MISC(display, cpu_transcoder),
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index ade7e51e7590..93282694c29b 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3164,7 +3164,7 @@ static void intel_dp_compute_vsc_sdp(struct
intel_dp *intel_dp,
        struct drm_dp_vsc_sdp *vsc;

        if ((!intel_dp->colorimetry_support ||
-            !intel_dp_needs_vsc_sdp(crtc_state, conn_state)) &&
+            !intel_dp_needs_vsc_colorimetry(crtc_state, conn_state)) &&
            !crtc_state->has_psr)
                return;

@@ -3174,7 +3174,7 @@ static void intel_dp_compute_vsc_sdp(struct
intel_dp *intel_dp,
        vsc->sdp_type = DP_SDP_VSC;

        /* Needs colorimetry */
-       if (intel_dp_needs_vsc_sdp(crtc_state, conn_state)) {
+       if (intel_dp_needs_vsc_colorimetry(crtc_state, conn_state)) {
                intel_dp_compute_vsc_colorimetry(crtc_state, conn_state,
                                                 vsc);
        } else if (crtc_state->has_panel_replay) { @@ -5100,8 +5100,8 @@
static bool intel_dp_get_and_ack_sink_irq_esi_sst(struct intel_dp *intel_dp,
u8  }

  bool
-intel_dp_needs_vsc_sdp(const struct intel_crtc_state *crtc_state,
-                      const struct drm_connector_state *conn_state)
+intel_dp_needs_vsc_colorimetry(const struct intel_crtc_state *crtc_state,
+                              const struct drm_connector_state *conn_state)
  {
        /*
         * As per DP 1.4a spec section 2.2.4.3 [MSA Field for Indication diff --
git a/drivers/gpu/drm/i915/display/intel_dp.h
b/drivers/gpu/drm/i915/display/intel_dp.h
index 02b691df6755..54570aa142f4 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.h
+++ b/drivers/gpu/drm/i915/display/intel_dp.h
@@ -128,8 +128,8 @@ int intel_dp_max_link_data_rate(struct intel_dp
*intel_dp,  bool intel_dp_joiner_needs_dsc(struct intel_display *display,
                               int num_joined_pipes);
  bool intel_dp_has_joiner(struct intel_dp *intel_dp); -bool
intel_dp_needs_vsc_sdp(const struct intel_crtc_state *crtc_state,
-                           const struct drm_connector_state *conn_state);
+bool intel_dp_needs_vsc_colorimetry(const struct intel_crtc_state
*crtc_state,
+                                   const struct drm_connector_state
*conn_state);
  void intel_dp_set_infoframes(struct intel_encoder *encoder, bool enable,
                             const struct intel_crtc_state *crtc_state,
                             const struct drm_connector_state *conn_state);
--
2.25.1


























					Reply via email to