> Subject: [PATCH 3/4] drm/i915/display: reduce indent in
> intel_atomic_commit_fence_wait()
> 
> Continue early in the loop for no fence in order to reduce indent.
> 
> v2: Rebase
> 
> Cc: Ville Syrjälä <[email protected]>
> Cc: Maarten Lankhorst <[email protected]>
> Signed-off-by: Jani Nikula <[email protected]>

LGTM,
Reviewed-by: Suraj Kandpal <[email protected]>

> 
> ---
> 
> Tip: 'git show -w' for easy review
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 1c2e50c6d98a..983e84bca1ee 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -7296,14 +7296,15 @@ static void
> intel_atomic_commit_fence_wait(struct intel_atomic_state *state)
>       int i;
> 
>       for_each_new_plane_in_state(&state->base, plane, new_plane_state,
> i) {
> -             if (new_plane_state->fence) {
> -                     ret = dma_fence_wait(new_plane_state->fence, false);
> -                     if (ret < 0)
> -                             break;
> +             if (!new_plane_state->fence)
> +                     continue;
> 
> -                     dma_fence_put(new_plane_state->fence);
> -                     new_plane_state->fence = NULL;
> -             }
> +             ret = dma_fence_wait(new_plane_state->fence, false);
> +             if (ret < 0)
> +                     break;
> +
> +             dma_fence_put(new_plane_state->fence);
> +             new_plane_state->fence = NULL;
>       }
>  }
> 
> --
> 2.47.3

Reply via email to