On 9/9/2026 9:47 PM, Ville Syrjala wrote:
From: Ville Syrjälä <[email protected]>
Warn if use_flipq==true in intel_pipe_update_{start,end}().
These functions are part of the MMIO based commit codepath,
so should never get there with use_flipq==true.
We were also warning about use_dsb==true for the same reason.
Typo on the commit subject: use_flipq
Other than that, LGTM.
Reviewed-by: Chaitanya Kumar Borah <[email protected]>
Signed-off-by: Ville Syrjälä <[email protected]>
---
drivers/gpu/drm/i915/display/intel_crtc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c
b/drivers/gpu/drm/i915/display/intel_crtc.c
index c7a85dce6aca..58a99c265598 100644
--- a/drivers/gpu/drm/i915/display/intel_crtc.c
+++ b/drivers/gpu/drm/i915/display/intel_crtc.c
@@ -596,7 +596,7 @@ void intel_pipe_update_start(struct intel_atomic_state
*state,
struct intel_vblank_evade_ctx evade;
int scanline;
- drm_WARN_ON(display->drm, new_crtc_state->use_dsb);
+ drm_WARN_ON(display->drm, new_crtc_state->use_dsb ||
new_crtc_state->use_flipq);
intel_psr_lock(new_crtc_state);
@@ -735,7 +735,7 @@ void intel_pipe_update_end(struct intel_atomic_state *state,
u32 end_vbl_count = intel_crtc_get_vblank_counter(crtc);
ktime_t end_vbl_time = ktime_get();
- drm_WARN_ON(display->drm, new_crtc_state->use_dsb);
+ drm_WARN_ON(display->drm, new_crtc_state->use_dsb ||
new_crtc_state->use_flipq);
if (new_crtc_state->do_async_flip)
goto out;
