On Wed, Aug 20, 2014 at 04:29:24PM +0100, Thomas Daniel wrote: > These two functions make no sense in an Logical Ring Context & Execlists > world. > > v2: We got rid of lrc_enabled and centralized everything in the sanitized > i915.enable_execlists instead. > > Signed-off-by: Oscar Mateo <oscar.ma...@intel.com> > > v3: Rebased. Corrected a typo in comment for i915_switch_context and > added a comment that it should not be called in execlist mode. Added > WARN_ON if i915_switch_context is called in execlist mode. Moved check > for execlist mode out of i915_switch_context and into callers. Added > comment in context_reset explaining why nothing is done in execlist > mode.
No, this is not the way. The requirement is to reduce the number of special cases not increase them. These should be evaluated to be no-ops when execlists is used. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
