The original patch works as it should. Substitution with user-defined characters only works in the "FROM_UNICODE" case. When converting to Unicode, U+FFFD is always substituted because it is the standard substitution character. Even the ICU library does not allow this to be changed (with good reason).
As for the test, *I think* the testing script would have to be Unicode-compatible and the test script would have to be in some UTF encoding to verify that U+FFFD was substituted. I don't know if this is the case yet. On Friday 21 March 2008 12:06:34 pm you wrote: > On 03/21/2008 06:28 PM, Geoffrey Sneddon wrote: > >> Patch committed, thanks. > > > > Can we test U_CONV_ERROR_SUBST too? See attached patch. Also, the bug > > should be closed. > > The patch breaks the test. > > Can you guys decide on what should work and how, I'll commit the patch > afterwards, ok? -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
