Moriyoshi Koizumi wrote: >> Regarding the patch (https://gist.github.com/835698): >> I don't see a switch to disable the internal parse on configure. > I don't see any obvious reason it should be able to be turned off > through the build option. The only problem is binary size increase, > which I guess is quite subtle. Seems sufficiently different from normal cli.
>> The patch looks messy as it splits main in two functions, so it gets >> hard to follow, >> but is probably good overall. > Assuming you are mentioning about the option parsing portion of the > code, yes, it's a bit messy, but I had to do so because runtime > initialization procedure is very different from the ordinary CLI. Wasn't critizising you. It's a limitation of unified diffs, which can't say "move this bunch of code 25 lines down". A bit hard to follow, but aparently good. >> The change from php_printf to printf in line 3988 looks wrong. > php_printf() eventually redirects the output to > sapi_module.ub_write(), which should only be available after proper > SAPI initialization. The changed part can be reached before the > initialization and it absolutely makes no sense to use php_printf() > when you simply want to print a message text before the script starts > in the console. Fair enough. >> Any special reason to disable it on PHP_CLI_WIN32_NO_CONSOLE ? > cli-win32 version of PHP doesn't have an associated console and is > supposed to use to create applications without console interactions > (i.e. GUI). So, It doesn't make sense to enable this feature for it. With the embedded web server, the interaction would be done via the browser. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
