2011/9/13 Ferenc Kovacs <tyr...@gmail.com>: > On Tue, Sep 13, 2011 at 6:23 PM, Stas Malyshev <smalys...@sugarcrm.com> wrote: >> Hi! >> >> On 9/13/11 7:49 AM, Ferenc Kovacs wrote: >>> >>> Stas, I still don't know why do have a custom php.ini, and why is it used. >>> The make test should create tmp-php.ini for you (and copy your >> >> Everybody has custom php.ini, what do you mean "why"? Nobody uses just >> defaults. It is used because -n -c is not passed when you run run-tests. > > not everybody, but I guess you are right that most people has a system > wide php installed with a custom php.ini on the machine that runs the > test suite. > to name an exception: I have a dedicate vm for building php and > running the tests, and there is no system wide php installed there, > hence no custom php.ini. > as I mentioned before, make test (at least it should) passes the -n -c > argument to run-tests.php > see > http://svn.php.net/viewvc/php/php-src/trunk/Makefile.global?view=markup#l104 > which means if you run make test that can produce different result, > than simply running run-tests.php
Why do we even have this tmp-php.ini? Why not just make test without any .ini files, i.e. just with -n option? > >> >>> additional ini files there if you passed --with-config-file-scan-dir >>> for the build) and pass -n -c tmp-php.ini as an argument to the >>> invidual tests. >> >> That is not what I see happening. I've already sent you the actual command >> line, there's no -n and -c there. > > And I already mentioned and pointed out, that make test should pass > those, the test target in the Makefile is pretty straightforward, so I > can't see how can your make test not pass -n -c tmp-php.ini > > For the record, before our discussion I wasn't aware that the > tmp-php.ini built by the make test can have "random" values(through > --with-config-file-scan-dir) and I expected that most of the test > results are generated through make test. > Now knowing this, I now understand that theoretically each test should > define every --INI-- value (except those set on > http://svn.php.net/viewvc/php/php-src/trunk/run-tests.php?view=markup#l224 > ) which could influence the result of the test. > Even stuff like memory_limit, as I could have a custom php.ini with > memory_limit=1 > > I'm pretty sure that I could screw up 99% of test results with a > properly adjusted php.ini. > > I think that it would be a good idea to set up some baseline(or extend > http://svn.php.net/viewvc/php/php-src/trunk/run-tests.php?view=markup#l224 > ) php.ini for the test suite, otherwise we will test not the testsuite > but the configuration. (somebody mentioned that it is intentional, but > I think it is a bad practice) > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu > -- Regards, Shein Alexey -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
