> From: Lu Baolu <baolu...@linux.intel.com>
> Sent: Tuesday, June 21, 2022 10:44 PM
> Tweak the I/O page fault handling framework to route the page faults to
> the domain and call the page fault handler retrieved from the domain.
> This makes the I/O page fault handling framework possible to serve more
> usage scenarios as long as they have an IOMMU domain and install a page
> fault handler in it. Some unused functions are also removed to avoid
> dead code.
> The iommu_get_domain_for_dev_pasid() which retrieves attached domain
> for a {device, PASID} pair is used. It will be used by the page fault
> handling framework which knows {device, PASID} reported from the iommu
> driver. We have a guarantee that the SVA domain doesn't go away during
> IOPF handling, because unbind() waits for pending faults with
> iopf_queue_flush_dev() before freeing the domain. Hence, there's no need
> to synchronize life cycle of the iommu domains between the unbind() and
> the interrupt threads.

I found iopf_queue_flush_dev() is only called in intel-iommu driver. Did
I overlook anything?

>  static void iopf_handle_group(struct work_struct *work)
>  {
>       struct iopf_group *group;
> +     struct iommu_domain *domain;
>       struct iopf_fault *iopf, *next;
>       enum iommu_page_response_code status =
>       group = container_of(work, struct iopf_group, work);
> +     domain = iommu_get_domain_for_dev_pasid(group->dev,
> +                             group->last_fault.fault.prm.pasid);
> +     if (!domain || !domain->iopf_handler)
> +             status = IOMMU_PAGE_RESP_INVALID;

Miss a comment on why no refcnt is required on domain as explained
in the commit msg.
iommu mailing list

Reply via email to