SteveStevenpoor commented on PR #26702: URL: https://github.com/apache/flink/pull/26702#issuecomment-2989678927
> I think we could simplify the joinKeys to be Set of < int > instead of Set < String > by just using the operand.index. Each join key has an absolute unique index if you take in consideration all inputs and maybe the code would be shorter. Wouldn't that work? In the first version I compared only indexes as you suggest, but if there is projection that changes the order of fields (like the one from RightToLeftJoinRule) the result could be wrong. Set of strings is more complex codewise but it can guarantee projection independence and it's good for debug. I think I could rethink using set of strings when working on RightToLeftJoin integration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
