SteveStevenpoor commented on code in PR #26702:
URL: https://github.com/apache/flink/pull/26702#discussion_r2158148456
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/stream/sql/MultiJoinTest.java:
##########
@@ -154,6 +163,16 @@ void testFourWayComplexJoinRelPlan() {
+ "LEFT JOIN Shipments s ON p.user_id_2 =
s.user_id_3");
}
+ @Test
+ void testFourWayJoinNoCJKRelPlan() {
+ util.verifyRelPlan(
+ "SELECT u.user_id_0, u.name, o.order_id, p.payment_id,
s.location "
+ + "FROM Users u "
+ + "LEFT JOIN Orders o ON u.user_id_0 = o.user_id_1 "
+ + "INNER JOIN Payments p ON u.user_id_0 = p.user_id_2 "
+ + "LEFT JOIN Shipments s ON p.payment_id =
s.user_id_3");
+ }
+
Review Comment:
haveCommonJoinKey actually return true in this case. False is returned in
this sample:
```
for (int joinKey : joinKeys) {
if (inputNullGenFieldList.get(joinKey + beginIndex))
{
return false;
}
}
```
Do we still need to track null generating fields? It seems for me like we
don't but I'm not sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
