gustavodemorais commented on code in PR #26702:
URL: https://github.com/apache/flink/pull/26702#discussion_r2158511911
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinToMultiJoinRule.java:
##########
@@ -503,52 +484,146 @@ private List<RexNode> combineJoinFilters(
* @param nullGenerating true if the input is null generating
* @return true if the input can be combined into a parent MultiJoin
*/
- private boolean canCombine(
- RelNode input,
- ImmutableIntList joinKeys,
- JoinRelType joinType,
- boolean nullGenerating,
- boolean isLeft,
- List<Boolean> inputNullGenFieldList,
- int beginIndex) {
+ private boolean canCombine(RelNode input, Join origJoin, boolean
nullGenerating) {
Review Comment:
nullGenerating can also be deleted.
- Since we don't need this
https://github.com/apache/flink/pull/26702/files#r2158505668
- For the other case it will be always false
https://github.com/apache/flink/pull/26702/files#diff-44d9c5d7695b96ec29f833777fcfd24c78c5e0a9d0dab52d4b5403ccd3a7d165R316
- Inside combineJoinInfo we also only have inner and left joins, which means
it's also always false there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
