gustavodemorais commented on code in PR #26702:
URL: https://github.com/apache/flink/pull/26702#discussion_r2158515902
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinToMultiJoinRule.java:
##########
@@ -372,15 +368,7 @@ private void combineJoinInfo(
JoinInfo joinInfo = joinRel.analyzeCondition();
ImmutableIntList leftKeys = joinInfo.leftKeys;
final RexBuilder rexBuilder = joinRel.getCluster().getRexBuilder();
- boolean leftCombined =
- canCombine(
- left,
- leftKeys,
- joinType,
- joinType.generatesNullsOnLeft(),
- true,
- inputNullGenFieldList,
- 0);
+ boolean leftCombined = canCombine(left, joinRel,
joinType.generatesNullsOnLeft());
switch (joinType) {
case LEFT:
if (leftCombined) {
Review Comment:
copyJoinInfo always sends null as the last two params and 0 as
adjustmentAmount, you can remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
