[
https://issues.apache.org/jira/browse/ARTEMIS-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958659#comment-15958659
]
ASF GitHub Bot commented on ARTEMIS-1095:
-----------------------------------------
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1176
ARTEMIS-1095 Netty's WriteBufferWaterMark configuration via
TransportConstants
By default Netty uses the write buffer high/low water mark to perform flow
control while on the event loop.
I've added the configuration (+ default) of these values and the
documentation that explain their purpose.
I've not changed too much the original default values defined by Netty to
not impact the current tests and known behaviours around the Netty transport
usage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/activemq-artemis
write_buffer_water_mark_config
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1176
----
commit 999659f4e2e70e0d5a064a6dcd84cb78eb4bcfd3
Author: Francesco Nigro <[email protected]>
Date: 2017-04-06T09:33:29Z
ARTEMIS-1095 Netty's WriteBufferWaterMark configuration via
TransportConstants
----
> Netty's WriteBufferWaterMark configuration via TransportConstants
> -----------------------------------------------------------------
>
> Key: ARTEMIS-1095
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1095
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
>
> By default Netty uses the write buffer high/low water mark to perform flow
> control while on the event loop.
> Currently these properties are not set in Artemis, that is not being flow
> controlled properly and is not seeing correct activation of the ReadyListener
> on NettyConnection when it is considered writable.
> I propose to define TransportConstants.NETTY_WRITE_BUFFER_LOW_WATER_MARK and
> TransportConstants.NETTY_WRITE_BUFFER_HIGH_WATER_MARK to set the Netty's ones.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
