[
https://issues.apache.org/jira/browse/ARTEMIS-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958858#comment-15958858
]
ASF GitHub Bot commented on ARTEMIS-1095:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1176#discussion_r110151986
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/TransportConstants.java
---
@@ -125,6 +125,10 @@
*/
public static final String NIO_REMOTING_THREADS_PROPNAME =
"nioRemotingThreads";
+ public static final String NETTY_WRITE_BUFFER_LOW_WATER_MARK_PROPNAME =
"nettyWriteBufferLowWaterMark";
--- End diff --
If you are exposing the parameter to users, can you rename it as
bufferLowWatermark
and bufferHighWaternark?
It's more independent from Netty and more user friendly.
> Netty's WriteBufferWaterMark configuration via TransportConstants
> -----------------------------------------------------------------
>
> Key: ARTEMIS-1095
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1095
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
>
> By default Netty uses the write buffer high/low water mark to perform flow
> control while on the event loop.
> Currently these properties are not set in Artemis, that is not being flow
> controlled properly and is not seeing correct activation of the ReadyListener
> on NettyConnection when it is considered writable.
> I propose to define TransportConstants.NETTY_WRITE_BUFFER_LOW_WATER_MARK and
> TransportConstants.NETTY_WRITE_BUFFER_HIGH_WATER_MARK to set the Netty's ones.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
