[
https://issues.apache.org/jira/browse/ARTEMIS-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958862#comment-15958862
]
ASF GitHub Bot commented on ARTEMIS-1095:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1176#discussion_r110152342
--- Diff: docs/user-manual/en/configuring-transports.md ---
@@ -239,6 +239,17 @@ Netty for simple TCP:
- `tcpReceiveBufferSize`. This parameter determines the size of the
TCP receive buffer in bytes. The default value for this property is
`32768` bytes (32KiB).
+
+- `nettyWriteBufferLowWaterMark`. This parameter determines the low
water mark of
+ the Netty write buffer. Once the number of bytes queued in the write
buffer exceeded
+ the high water mark and then dropped down below this value, Netty's
channel
+ will start to be writable again. The default value for this property
is
+ `32768` bytes (32KiB).
+
+- `nettyWriteBufferHighWaterMark`. This parameter determines the high
water mark of
+ the Netty write buffer. If the number of bytes queued in the write
buffer exceeds
+ this value, Netty's channel will start to be not writable. The default
value for
+ this property is `131072` bytes (128KiB).
--- End diff --
Can you add a test where you validate this parameter through an URI?
Look for a test parsing the Connector and Acceptor, and validate if the
value was parsed, please?
I will need this PR done ASAP, as I was doing something similar on my
replication tests.
> Netty's WriteBufferWaterMark configuration via TransportConstants
> -----------------------------------------------------------------
>
> Key: ARTEMIS-1095
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1095
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
>
> By default Netty uses the write buffer high/low water mark to perform flow
> control while on the event loop.
> Currently these properties are not set in Artemis, that is not being flow
> controlled properly and is not seeing correct activation of the ReadyListener
> on NettyConnection when it is considered writable.
> I propose to define TransportConstants.NETTY_WRITE_BUFFER_LOW_WATER_MARK and
> TransportConstants.NETTY_WRITE_BUFFER_HIGH_WATER_MARK to set the Netty's ones.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
