[
https://issues.apache.org/jira/browse/ARTEMIS-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958667#comment-15958667
]
ASF GitHub Bot commented on ARTEMIS-1095:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1176
@clebertsuconic @mtaylor This setting could (positively, hopefully) impact
on some of your use cases we have discussed. Defining "sane" values seems to
affect when Netty's event loop "wakeup" and perform any writes.
[Here](http://normanmaurer.me/presentations/2014-twitter-meetup-netty/slides.html#9.0)
is the critical point about it.
> Netty's WriteBufferWaterMark configuration via TransportConstants
> -----------------------------------------------------------------
>
> Key: ARTEMIS-1095
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1095
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
>
> By default Netty uses the write buffer high/low water mark to perform flow
> control while on the event loop.
> Currently these properties are not set in Artemis, that is not being flow
> controlled properly and is not seeing correct activation of the ReadyListener
> on NettyConnection when it is considered writable.
> I propose to define TransportConstants.NETTY_WRITE_BUFFER_LOW_WATER_MARK and
> TransportConstants.NETTY_WRITE_BUFFER_HIGH_WATER_MARK to set the Netty's ones.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
