[
https://issues.apache.org/jira/browse/ARTEMIS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452293#comment-16452293
]
ASF GitHub Bot commented on ARTEMIS-1829:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2044#discussion_r184067483
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/plugin/ActiveMQServerPlugin.java
---
@@ -566,7 +566,7 @@ default void messageExpired(MessageReference message,
SimpleString messageExpiry
* @throws ActiveMQException
*/
default void messageExpired(MessageReference message, SimpleString
messageExpiryAddress, ServerConsumer consumer) throws ActiveMQException {
-
--- End diff --
these were part of a release... i wouldn't remove them... besides they
don't bother anything.
> Remove deprecated plugin's messageExpired implementations
> ---------------------------------------------------------
>
> Key: ARTEMIS-1829
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1829
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.5.0
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
> Fix For: 2.5.1
>
>
> NotificationActiveMQServerPlugin and LoggingActiveMQServerPlugin are
> implementing the deprecated version of ActiveMQServerPlugin::messageExpired
> that is not called by the new version of the method nor any other part of the
> code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
