[ 
https://issues.apache.org/jira/browse/ARTEMIS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452320#comment-16452320
 ] 

ASF GitHub Bot commented on ARTEMIS-1829:
-----------------------------------------

Github user cshannon commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2044
  
    Oops, yeah this is the correct fix.  The new default method would call off 
to the old one as it's default if nothing overrides it to stay backwards 
compatible.  And then with Artemis 3.0.0 we can remove all the deprecated 
default methods altogether.


> Remove deprecated plugin's messageExpired implementations
> ---------------------------------------------------------
>
>                 Key: ARTEMIS-1829
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1829
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.5.0
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Minor
>             Fix For: 2.5.1
>
>
> NotificationActiveMQServerPlugin and LoggingActiveMQServerPlugin are 
> implementing the deprecated version of ActiveMQServerPlugin::messageExpired 
> that is not called by the new version of the method nor any other part of the 
> code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to