[
https://issues.apache.org/jira/browse/ARTEMIS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452895#comment-16452895
]
ASF GitHub Bot commented on ARTEMIS-1829:
-----------------------------------------
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2044
I see...
Can I ask you a favor... if a test for your change doesn't make sense, can
you explicitly add a comment to your commit message saying "a test is not
needed"?
I'm being through the commit list and always looking when tests are needed
now.. if a test doesn't make sense on this one.. please add a comment so it's
registered for when we go through this in the future.
> Remove deprecated plugin's messageExpired implementations
> ---------------------------------------------------------
>
> Key: ARTEMIS-1829
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1829
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.5.0
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
> Fix For: 2.5.1
>
>
> NotificationActiveMQServerPlugin and LoggingActiveMQServerPlugin are
> implementing the deprecated version of ActiveMQServerPlugin::messageExpired
> that is not called by the new version of the method nor any other part of the
> code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
