[
https://issues.apache.org/jira/browse/ARTEMIS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452328#comment-16452328
]
ASF GitHub Bot commented on ARTEMIS-1829:
-----------------------------------------
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2044
@franz1981 - You should probably also update the tests as well. The
MethodCalledVerifier class implements ActiveMQServerPlugin in the integration
tests project and should probably have its messageExpired method signature
updated as well although it should still work as is with your change.
> Remove deprecated plugin's messageExpired implementations
> ---------------------------------------------------------
>
> Key: ARTEMIS-1829
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1829
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.5.0
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
> Fix For: 2.5.1
>
>
> NotificationActiveMQServerPlugin and LoggingActiveMQServerPlugin are
> implementing the deprecated version of ActiveMQServerPlugin::messageExpired
> that is not called by the new version of the method nor any other part of the
> code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
