[
https://issues.apache.org/jira/browse/ARTEMIS-2311?focusedWorklogId=229371&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229371
]
ASF GitHub Bot logged work on ARTEMIS-2311:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/19 21:05
Start Date: 17/Apr/19 21:05
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2627:
ARTEMIS-2311 Dealing with Protocol conversions and JMSReplyTo
URL: https://github.com/apache/activemq-artemis/pull/2627#discussion_r276433146
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/CoreAmqpConverter.java
##########
@@ -173,9 +174,12 @@ public static AMQPMessage fromCore(ICoreMessage
coreMessage) throws Exception {
properties.setTo(toAddress(destination));
maMap.put(JMS_DEST_TYPE_MSG_ANNOTATION, destinationType(destination));
}
- Destination replyTo = message.getJMSReplyTo();
Review comment:
why not? would make it cleaner. Out of query why did we create our own JMS
representation of amqp qpid bits, when actually already qpid-jms has done this
and could have simply passed it the proton message and let it represent the JMS
Message. Then it would make JMS to JMS much cleaner, as you would parse it
through the same mapping logic we have to handle any foreign JMS message when
you do a JMS produce.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 229371)
Time Spent: 6h 10m (was: 6h)
> JMSReplyTo insconsistent when dealing with Protocol conversions
> ---------------------------------------------------------------
>
> Key: ARTEMIS-2311
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2311
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP, Broker, OpenWire
> Affects Versions: 2.7.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.8.0
>
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
