[
https://issues.apache.org/jira/browse/ARTEMIS-2311?focusedWorklogId=229374&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229374
]
ASF GitHub Bot logged work on ARTEMIS-2311:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/19 21:09
Start Date: 17/Apr/19 21:09
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2627:
ARTEMIS-2311 Dealing with Protocol conversions and JMSReplyTo
URL: https://github.com/apache/activemq-artemis/pull/2627#discussion_r276434984
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
##########
@@ -196,7 +200,21 @@ private OpenWireMessageConverter() {
final ActiveMQDestination replyTo = messageSend.getReplyTo();
if (replyTo != null) {
- putMsgReplyTo(replyTo, marshaller, coreMessage);
+ if (replyTo instanceof TemporaryQueue) {
+ MessageUtil.setJMSReplyTo(coreMessage,
org.apache.activemq.artemis.jms.client.ActiveMQDestination.TEMP_QUEUE_QUALIFED_PREFIX
+ (((TemporaryQueue) replyTo).getQueueName()));
Review comment:
Same query i put on the AMQP one but also relevant i think here, but why
dont we use the same logic when you transform a JMS Message for foreign
Messages on producer send (which you have to handle as part of TCK)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 229374)
Time Spent: 6h 40m (was: 6.5h)
> JMSReplyTo insconsistent when dealing with Protocol conversions
> ---------------------------------------------------------------
>
> Key: ARTEMIS-2311
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2311
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP, Broker, OpenWire
> Affects Versions: 2.7.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.8.0
>
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
