[
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=443251&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443251
]
ASF GitHub Bot logged work on ARTEMIS-2797:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/20 16:47
Start Date: 09/Jun/20 16:47
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#discussion_r437564056
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -689,7 +689,10 @@ public QueueBinding updateQueue(QueueConfiguration
queueConfiguration) throws Ex
queue.setDelayBeforeDispatch(queueConfiguration.getDelayBeforeDispatch().longValue());
}
Filter filter =
FilterImpl.createFilter(queueConfiguration.getFilterString());
- if (filter != null && !filter.equals(queue.getFilter())) {
+ if ((filter == null) && (queue.getFilter() != null)) {
Review comment:
Should think about applying the same to all, e.g. if now null set back
to default for address setting (or static default)
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -689,7 +689,10 @@ public QueueBinding updateQueue(QueueConfiguration
queueConfiguration) throws Ex
queue.setDelayBeforeDispatch(queueConfiguration.getDelayBeforeDispatch().longValue());
}
Filter filter =
FilterImpl.createFilter(queueConfiguration.getFilterString());
- if (filter != null && !filter.equals(queue.getFilter())) {
+ if ((filter == null) && (queue.getFilter() != null)) {
Review comment:
Should think about applying the same to all, e.g. if now null set back
to default for address setting (or static default) else some users will get
different behaviour of what update does per queue config. We should have
uniform behaviour across all. E.g. if support here should have similar logic ob
all. And also def requires doc updates
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -689,7 +689,10 @@ public QueueBinding updateQueue(QueueConfiguration
queueConfiguration) throws Ex
queue.setDelayBeforeDispatch(queueConfiguration.getDelayBeforeDispatch().longValue());
}
Filter filter =
FilterImpl.createFilter(queueConfiguration.getFilterString());
- if (filter != null && !filter.equals(queue.getFilter())) {
+ if ((filter == null) && (queue.getFilter() != null)) {
Review comment:
Should think about applying the same to all, e.g. if now null set back
to default for address setting (or static default) else some users will get
different behaviour of what update does per queue config. We should have
uniform behaviour across all. E.g. if support here should have similar logic ob
all. And also def requires doc updates, and a call out in behaviour changes in
release notes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 443251)
Time Spent: 0.5h (was: 20m)
> Allow for removing current queue filter
> ---------------------------------------
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.13.0
> Reporter: Jan Šmucr
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.14.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently the queue filter cannot be removed because of a filter ~ null check
> leading to quitting the PostOfficeImpl#updateQueue() instead of setting the
> queue filter to empty.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
