[
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=443582&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443582
]
ASF GitHub Bot logged work on ARTEMIS-2797:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/20 06:41
Start Date: 10/Jun/20 06:41
Worklog Time Spent: 10m
Work Description: jsmucr commented on a change in pull request #3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#discussion_r437892289
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -689,7 +689,10 @@ public QueueBinding updateQueue(QueueConfiguration
queueConfiguration) throws Ex
queue.setDelayBeforeDispatch(queueConfiguration.getDelayBeforeDispatch().longValue());
}
Filter filter =
FilterImpl.createFilter(queueConfiguration.getFilterString());
- if (filter != null && !filter.equals(queue.getFilter())) {
+ if ((filter == null) && (queue.getFilter() != null)) {
Review comment:
I've added the config reload test.
I'm not sure about what you mean by the default behavior. Shall I add some
sort of constant (like `DEFAULT_FILTER`) or just document the fact that there's
no filter by default and that setting it to `null` (by removing it from the
configuration) or to `""` reverts it back to the default value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 443582)
Time Spent: 40m (was: 0.5h)
> Allow for removing current queue filter
> ---------------------------------------
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.13.0
> Reporter: Jan Šmucr
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.14.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently the queue filter cannot be removed because of a filter ~ null check
> leading to quitting the PostOfficeImpl#updateQueue() instead of setting the
> queue filter to empty.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
