[
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=443588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443588
]
ASF GitHub Bot logged work on ARTEMIS-2797:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/20 07:10
Start Date: 10/Jun/20 07:10
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#discussion_r437904731
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -689,7 +689,10 @@ public QueueBinding updateQueue(QueueConfiguration
queueConfiguration) throws Ex
queue.setDelayBeforeDispatch(queueConfiguration.getDelayBeforeDispatch().longValue());
}
Filter filter =
FilterImpl.createFilter(queueConfiguration.getFilterString());
- if (filter != null && !filter.equals(queue.getFilter())) {
+ if ((filter == null) && (queue.getFilter() != null)) {
Review comment:
I was meaning other queue configurations that you can update e.g like
the one immediately above delaybeforedispatch. E.g. if change of behaviour from
currently if null do not update, now youre proposing to make it if null set
back to default which for filter is null. We would want that behaviour
consistent. Else we end up with some ignoring and some reverting.
Its very important behaviour is consistent for all, so either all do nothing
when new value is null (ignore) current behaviour before your proposed change
or all update back to their defaults (being either the default at address
setting or where a default constant its used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 443588)
Time Spent: 1h (was: 50m)
> Allow for removing current queue filter
> ---------------------------------------
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.13.0
> Reporter: Jan Šmucr
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.14.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently the queue filter cannot be removed because of a filter ~ null check
> leading to quitting the PostOfficeImpl#updateQueue() instead of setting the
> queue filter to empty.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
