[
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=443589&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443589
]
ASF GitHub Bot logged work on ARTEMIS-2797:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/20 07:13
Start Date: 10/Jun/20 07:13
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#discussion_r437906371
##########
File path:
tests/integration-tests/src/test/resources/reload-queue-filter-updated-empty.xml
##########
@@ -0,0 +1,43 @@
+<?xml version='1.0'?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<configuration xmlns="urn:activemq"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="urn:activemq
/schema/artemis-configuration.xsd">
+
+ <core xmlns="urn:activemq:core">
+ <security-enabled>false</security-enabled>
+ <persistence-enabled>false</persistence-enabled>
+
+ <acceptors>
+ <acceptor name="artemis">tcp://0.0.0.0:61616</acceptor>
+ </acceptors>
+
+ <addresses>
+ <address name="myFilterQueue">
+ <anycast>
+ <queue name="myFilterQueue">
+ <filter string=""/>
Review comment:
This isnt filtering. I would expect the test to be a real filter string
not an empty one. Empty filter is same as no filter so this isnt validating much
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 443589)
Time Spent: 1h 10m (was: 1h)
> Allow for removing current queue filter
> ---------------------------------------
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.13.0
> Reporter: Jan Šmucr
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.14.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently the queue filter cannot be removed because of a filter ~ null check
> leading to quitting the PostOfficeImpl#updateQueue() instead of setting the
> queue filter to empty.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
