[
https://issues.apache.org/jira/browse/ARTEMIS-3074?focusedWorklogId=537846&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-537846
]
ASF GitHub Bot logged work on ARTEMIS-3074:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/21 15:00
Start Date: 19/Jan/21 15:00
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on a change in pull
request #3412:
URL: https://github.com/apache/activemq-artemis/pull/3412#discussion_r560240289
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##########
@@ -3796,19 +3796,58 @@ public void createBridge(final String name,
final boolean ha,
final String user,
final String password) throws Exception {
+ createBridge(name,
+ queueName,
+ forwardingAddress,
+ filterString,
+ transformerClassName,
+ retryInterval,
+ retryIntervalMultiplier,
+ initialConnectAttempts,
+ reconnectAttempts,
+ useDuplicateDetection,
+ confirmationWindowSize,
+ clientFailureCheckPeriod,
+ staticConnectorsOrDiscoveryGroup,
+ useDiscoveryGroup,
+ ha,
+ user,
+ password,
+ ActiveMQClient.DEFAULT_CALL_TIMEOUT);
+ }
+
+ @Override
+ public void createBridge(final String name,
+ final String queueName,
+ final String forwardingAddress,
+ final String filterString,
+ final String transformerClassName,
+ final long retryInterval,
+ final double retryIntervalMultiplier,
+ final int initialConnectAttempts,
+ final int reconnectAttempts,
+ final boolean useDuplicateDetection,
+ final int confirmationWindowSize,
+ final long clientFailureCheckPeriod,
+ final String staticConnectorsOrDiscoveryGroup,
+ boolean useDiscoveryGroup,
+ final boolean ha,
+ final String user,
+ final String password,
+ final long callTimeout) throws Exception {
Review comment:
Make this Long, then you can use check on null if to set in config or
not. shouldnt be defaulting it at this layer, thats for lower downs to handle,
else in future if we change how config item works, we will forget all about
this stuff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 537846)
Time Spent: 40m (was: 0.5h)
> Add ActiveMQServerControl#createBridge() method variant which accepts the
> callTimeout attribute
> -----------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-3074
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3074
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.16.0
> Reporter: Tomas Hofman
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently there are four variants of the
> {{ActiveMQServerControl#createBridge()}} method, none of which accepts the
> {{callTimeout}} attribute of the core bridge.
> The {{callTimeout}} attribute sets a call timeout for blocking calls to the
> server. Typically a bridge works in a non-blocking manner, but in some cases
> customers use configurations where calls do block.
> It would still be possible to set call timeout without this change using
> lower level API ({{ActiveMQServer#deployBridge()}}), but it would require
> duplicating some code which is already there in {{ActiveMQServerControl}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
