[
https://issues.apache.org/jira/browse/ARTEMIS-3074?focusedWorklogId=538444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-538444
]
ASF GitHub Bot logged work on ARTEMIS-3074:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/21 13:45
Start Date: 20/Jan/21 13:45
Worklog Time Spent: 10m
Work Description: TomasHofman commented on pull request #3412:
URL: https://github.com/apache/activemq-artemis/pull/3412#issuecomment-763614891
@jbertram I implemented the `createBridge(jsonString)` method, can you check
if it is what you imagined?
I didn't move the `BridgeConfiguration` class into `activemq-commons` module
as it wasn't necessary in the scope of work I did. It rather looked problematic
as I would have to move other classes with it (`ActiveMQDefaultConfiguration`,
`ActiveMQClient`, `ComponentConfigurationRoutingType`) which
`BridgeConfiguration` depends on.
If we were to move it out of `activemq-server` module, would the
`artemis-core-client` module be a suitable place? This seems easier judging
from how the classes are coupled, and it would allow also us to create method
`ActiveMQServerControl#createBridge(BridgeConfiguration)` :), which may be nice
type safe addition to the JSON string version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 538444)
Time Spent: 1h 40m (was: 1.5h)
> Add ActiveMQServerControl#createBridge() method variant which accepts the
> callTimeout attribute
> -----------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-3074
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3074
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.16.0
> Reporter: Tomas Hofman
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently there are four variants of the
> {{ActiveMQServerControl#createBridge()}} method, none of which accepts the
> {{callTimeout}} attribute of the core bridge.
> The {{callTimeout}} attribute sets a call timeout for blocking calls to the
> server. Typically a bridge works in a non-blocking manner, but in some cases
> customers use configurations where calls do block.
> It would still be possible to set call timeout without this change using
> lower level API ({{ActiveMQServer#deployBridge()}}), but it would require
> duplicating some code which is already there in {{ActiveMQServerControl}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
