[
https://issues.apache.org/jira/browse/ARTEMIS-3074?focusedWorklogId=537901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-537901
]
ASF GitHub Bot logged work on ARTEMIS-3074:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/21 16:59
Start Date: 19/Jan/21 16:59
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #3412:
URL: https://github.com/apache/activemq-artemis/pull/3412#issuecomment-762978719
Given the proliferation of overloaded management methods it was determined
awhile back that we'd move to a more de-coupled approach using flexible
JSON-based input. See, for example, the method
`org.apache.activemq.artemis.api.core.management.ActiveMQServerControl#createQueue(java.lang.String)`
which replaces over 10 overloaded variants. The JSON input `String` for this
method can be created manually simply based on the parameter names or generated
from the `org.apache.activemq.artemis.api.core.QueueConfiguration` object using
the `toJSON` method. I recommend you implement a similar method for
`createBridge`. The class
`org.apache.activemq.artemis.core.config.BridgeConfiguration` already exists
and you can use that for these changes (although you'll likely need to move it
out of the `activemq-server` module and into the `activemq-commons` module).
I realize the change I'm describing is much larger than the one you already
submitted in this PR, but the new method in this PR is just going to be
deprecated in a bit so you'll have to change your integration code anyway. I
think it's probably best to do it "right" the first time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 537901)
Time Spent: 50m (was: 40m)
> Add ActiveMQServerControl#createBridge() method variant which accepts the
> callTimeout attribute
> -----------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-3074
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3074
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.16.0
> Reporter: Tomas Hofman
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently there are four variants of the
> {{ActiveMQServerControl#createBridge()}} method, none of which accepts the
> {{callTimeout}} attribute of the core bridge.
> The {{callTimeout}} attribute sets a call timeout for blocking calls to the
> server. Typically a bridge works in a non-blocking manner, but in some cases
> customers use configurations where calls do block.
> It would still be possible to set call timeout without this change using
> lower level API ({{ActiveMQServer#deployBridge()}}), but it would require
> duplicating some code which is already there in {{ActiveMQServerControl}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
