[
https://issues.apache.org/jira/browse/ARTEMIS-3341?focusedWorklogId=609838&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609838
]
ASF GitHub Bot logged work on ARTEMIS-3341:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/21 17:31
Start Date: 10/Jun/21 17:31
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #3618:
URL: https://github.com/apache/activemq-artemis/pull/3618#issuecomment-858816830
Why not use this in `checkstyle.xml`:
```xml
<module name="RightCurly">
<property name="option" value="alone_or_singleline"/>
<property name="tokens" value="METHOD_DEF, CTOR_DEF"/>
</module>
```
Then you could drop your changes from `TypedProperties` and
`AbstractJDBCDriver` and everything would be consistent.
As it stands now the change looks a bit strange because you're eliminating a
newline in `SensitiveDataCodec` and adding one in the other two aforementioned
classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 609838)
Time Spent: 20m (was: 10m)
> update checkstyle, use consistent plugin version
> ------------------------------------------------
>
> Key: ARTEMIS-3341
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3341
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 2.18.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Update checkstyle. Use consistent plugin version. Some [trivial] code changes
> are made too due to updated behaviour, and also a config tweak to allow
> various existing "noOpMethod \{ }" instances to remain.
> This only updates to 8.29 rather the the latest, to get rid of the warning
> from GitHub for a CVE, per https://github.com/advisories/GHSA-763g-fqq7-48wg.
> Going to the newest versions will require more extensive changes to the code
> and/or config.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
