[
https://issues.apache.org/jira/browse/ARTEMIS-3341?focusedWorklogId=609874&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609874
]
ASF GitHub Bot logged work on ARTEMIS-3341:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/21 18:39
Start Date: 10/Jun/21 18:39
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #3618:
URL: https://github.com/apache/activemq-artemis/pull/3618#issuecomment-858892553
> I actually prefer class definitions having the newline so I just went with
the default.
By "class" do you mean "constructor"? The checkstyle `CLASS_DEF` and
`CTOR_DEF` are different things, and I was talking about the latter.
> ...I just made it consistent with all the other default and empty methods
that would have needed updated if not for config tweak.
There doesn't appear to be a consistent style for right curly brackets for
`default` method definitions. A quick search through the code-base with a
regular expression indicates that the newline version is far more prevalent
than the single-line version. Only a few files use the single-line version with
`org.apache.activemq.artemis.protocol.amqp.proton.handler.EventHandler` being
the main culprit.
I don't really care *what* the style is. I just think it should be
consistent across all method definitions, whether those be constructors,
`default` methods, or normal methods. Given that and your preference for
newlines for constructors (assuming that's what you meant) then I'd say you
should just revert your change to `checkstyle.xml` and update the classes that
violate the style as it is enforced with the new version. I believe that was
what the original style intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 609874)
Time Spent: 40m (was: 0.5h)
> update checkstyle, use consistent plugin version
> ------------------------------------------------
>
> Key: ARTEMIS-3341
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3341
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 2.18.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Update checkstyle. Use consistent plugin version. Some [trivial] code changes
> are made too due to updated behaviour, and also a config tweak to allow
> various existing "noOpMethod \{ }" instances to remain.
> This only updates to 8.29 rather the the latest, to get rid of the warning
> from GitHub for a CVE, per https://github.com/advisories/GHSA-763g-fqq7-48wg.
> Going to the newest versions will require more extensive changes to the code
> and/or config.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
