[
https://issues.apache.org/jira/browse/ARTEMIS-3341?focusedWorklogId=609884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609884
]
ASF GitHub Bot logged work on ARTEMIS-3341:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/21 19:06
Start Date: 10/Jun/21 19:06
Worklog Time Spent: 10m
Work Description: gemmellr commented on pull request #3618:
URL: https://github.com/apache/activemq-artemis/pull/3618#issuecomment-858927264
I did mean constructor, per the context. I actually disagree that methods
and constuctors need to be treated the same, I consider them different things
and I think having the constructor with the newline makes them stand out better
and is more readable. For empty methods I don't see the need to enforce that,
they often look better without. That there are only 2 constructors affected
that way (but more methods affected the other) also suggest that was the
prevailing preference up to this point, as clearly the old checkstyle wasn't
enforcing it either way whereas the new one does. So all round I prefer what I
did.
Ultimately I don't care enough about this to argue any more over it though,
but I also won't invest any more time on adding newlines to all the methods
affected, as I don't actually think that is needed, better looking, or more
consistent.
I was only interested in getting rid of the CVE warning so that other
warnings can be more easily seen as they arise.
This proved way way more of a headache than expected and really is not worth
the hassle it took to even get it to this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 609884)
Time Spent: 1h (was: 50m)
> update checkstyle, use consistent plugin version
> ------------------------------------------------
>
> Key: ARTEMIS-3341
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3341
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 2.18.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Update checkstyle. Use consistent plugin version. Some [trivial] code changes
> are made too due to updated behaviour, and also a config tweak to allow
> various existing "noOpMethod \{ }" instances to remain.
> This only updates to 8.29 rather the the latest, to get rid of the warning
> from GitHub for a CVE, per https://github.com/advisories/GHSA-763g-fqq7-48wg.
> Going to the newest versions will require more extensive changes to the code
> and/or config.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
