[
https://issues.apache.org/jira/browse/ARTEMIS-3341?focusedWorklogId=610143&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-610143
]
ASF GitHub Bot logged work on ARTEMIS-3341:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/21 07:21
Start Date: 14/Jun/21 07:21
Worklog Time Spent: 10m
Work Description: jbertram opened a new pull request #3619:
URL: https://github.com/apache/activemq-artemis/pull/3619
As a follow-up to dc7de893747b90b627d729f9f18a758bb4dad9d5 I'm updating
checkstyle to the latest version, restoring the originally intended
"RightCurly" style, and updating all the code to properly adhere to the
style as enforced by the new checkstyle version.
The version of checkstyle we used before the aforementioned commit had
a bug which didn't properly enforced our intended "RightCurly" style
(see https://github.com/checkstyle/checkstyle/issues/6345). That commit
changed the style to accommodate the handful of unintended style
violations. This commit reverts that change for 2 main reasons:
- The style was always intended to use `alone` for both `METHOD_DEF`
and `CTOR_DEF`.
- There are over 1,000 existing uses of the intended style and around
30 violations of this style which were unintentionally allowed.
Reverting the style back to the original and cleaning up the unintented
violations makes the code more consistent and prevents further style
inconsistencies in the future.
There were a handful of other changes related to checkstyle bugs which
allowed unintended style violations. These were related to indentation
levels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 610143)
Time Spent: 1.5h (was: 1h 20m)
> update checkstyle, use consistent plugin version
> ------------------------------------------------
>
> Key: ARTEMIS-3341
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3341
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 2.18.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Update checkstyle. Use consistent plugin version. Some [trivial] code changes
> are made too due to updated behaviour.
> This aims to get rid of the warning from GitHub on checkin for a CVE, per
> [https://github.com/advisories/GHSA-763g-fqq7-48wg].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
