[
https://issues.apache.org/jira/browse/ARTEMIS-3493?focusedWorklogId=653985&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-653985
]
ASF GitHub Bot logged work on ARTEMIS-3493:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/21 09:14
Start Date: 22/Sep/21 09:14
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3766:
URL: https://github.com/apache/activemq-artemis/pull/3766#discussion_r713748804
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java
##########
@@ -150,6 +150,26 @@ String sendMessage(@Parameter(name = "headers", desc =
"The headers to add to th
@Parameter(name = "user", desc = "The user to
authenticate with") String user,
@Parameter(name = "password", desc = "The users password
to authenticate with") String password) throws Exception;
+ /**
+ * @param headers the message headers and properties to set. Can only
+ * container Strings maped to primitive types.
+ * @param body the text to send
+ * @param durable
+ * @param user
+ * @param password @return
+ * @param createUserId whether or not to auto generate a userID, used as a
Message ID in JMS
+ * @throws Exception
+ */
+ @Operation(desc = "Sends a TextMessage to a password-protected address.",
impact = MBeanOperationInfo.ACTION)
+ String sendMessage(@Parameter(name = "headers", desc = "The headers to add
to the message") Map<String, String> headers,
+ @Parameter(name = "type", desc = "A type for the
message") int type,
+ @Parameter(name = "body", desc = "The body (byte[]) of
the message encoded as a string using Base64") String body,
+ @Parameter(name = "durable", desc = "Whether the message
is durable") boolean durable,
+ @Parameter(name = "user", desc = "The user to
authenticate with") String user,
+ @Parameter(name = "password", desc = "The users password
to authenticate with") String password,
+ @Parameter(name = "createUserId", desc = "whether or not
to auto generate a userID, used as a Message ID in JMS") boolean createUserId)
throws Exception;
Review comment:
Why not just say 'addMessageId'? Continuing to reference this 'userId'
concept, when its absolutely about a message-id, and definitely not a userId,
and then having to document that it is a message id, just seems unnecessarily
confusing.
EDIT: I see Gary ninja'd me, though in regards to the UI. I would apply the
point throughout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 653985)
Time Spent: 40m (was: 0.5h)
> expose the User ID in the send message tab in console
> -----------------------------------------------------
>
> Key: ARTEMIS-3493
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3493
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Andy Taylor
> Assignee: Andy Taylor
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> this field in the core message is used to keep the JMS Message ID, it would
> be nice to have one auto generated if a checkbox is checked
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
