[
https://issues.apache.org/jira/browse/ARTEMIS-3493?focusedWorklogId=655385&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-655385
]
ASF GitHub Bot logged work on ARTEMIS-3493:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/21 08:16
Start Date: 27/Sep/21 08:16
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3766:
URL: https://github.com/apache/activemq-artemis/pull/3766#discussion_r716453308
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java
##########
@@ -150,6 +150,26 @@ String sendMessage(@Parameter(name = "headers", desc =
"The headers to add to th
@Parameter(name = "user", desc = "The user to
authenticate with") String user,
@Parameter(name = "password", desc = "The users password
to authenticate with") String password) throws Exception;
+ /**
+ * @param headers the message headers and properties to set. Can only
+ * container Strings maped to primitive types.
+ * @param body the text to send
+ * @param durable
+ * @param user
+ * @param password @return
+ * @param createMessageId whether or not to auto generate a userID, used as
a Message ID in JMS
Review comment:
javadoc description needs similarly revised
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/QueueControl.java
##########
@@ -565,6 +565,25 @@ String sendMessage(@Parameter(name = "headers", desc =
"The headers to add to th
@Parameter(name = "user", desc = "The user to
authenticate with") String user,
@Parameter(name = "password", desc = "The users password
to authenticate with") String password) throws Exception;
+ /**
+ * @param headers the message headers and properties to set. Can only
+ * container Strings maped to primitive types.
+ * @param body the text to send
+ * @param durable
+ * @param user
+ * @param password @return
+ * @param createMessageId whether or not to auto generate a userID, used as
a Message ID in JMS
Review comment:
Same
##########
File path:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/addressSendMessage.js
##########
@@ -98,7 +112,23 @@ var Artemis;
be null.
</p>
</div>
- </script>
+ </script>
+ <script type="text/ng-template" id="message-id-info.html">
+ <div>
+ <p>
+ The Message ID is an automatically generated UUID that is
set on the Message by the broker before it is routed.
+ If using a JMS client this would be the JMS Message ID on
the JMS Message, this typically would not get
+ set for non JMS clients. Historically and on some other
tabs this is also referred to as the User ID.
+ </p>
+ </div>
+ </script>
+ <script type="text/ng-template" id="durable-info.html">
+ <div>
+ <p>
+ If durable the message will be marked persistent and
written to the brokers journal.
Review comment:
[if the destination queue is durable] ?
##########
File path:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/sendMessage.js
##########
@@ -98,7 +112,23 @@ var Artemis;
be null.
</p>
</div>
- </script>
+ </script>
+ <script type="text/ng-template" id="message-id-info.html">
+ <div>
+ <p>
+ The Message ID is an automatically generated UUID that is
set on the Message by the broker before it is routed.
+ If using a JMS client this would be the JMS Message ID on
the JMS Message, this typically would not get
+ set for non JMS clients. Historically and on some other
tabs this is also referred to as the User ID.
+ </p>
+ </div>
+ </script>
+ <script type="text/ng-template" id="durable-info.html">
+ <div>
+ <p>
+ If durable the message will be marked persistent and
written to the brokers journal.
Review comment:
Same as other.
##########
File path:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/addressSendMessage.js
##########
@@ -42,6 +42,20 @@ var Artemis;
<div class="form-group">
<label>Durable </label>
<input id="durable" type="checkbox"
ng-model="$ctrl.message.durable" value="true">
+ <button type="button" class="btn btn-link
jvm-title-popover"
+
uib-popover-template="'durable-info.html'" popover-placement="bottom-left"
+ popover-title="Durable"
popover-trigger="'mouseenter'">
+ <span class="pficon pficon-info"></span>
+ </button>
+ </div>
+ <div class="form-group">
+ <label>Create User ID </label>
+ <input id="messageID" type="checkbox"
ng-model="$ctrl.message.messageID" value="true">
Review comment:
Label needs updated (line 52 if this isnt clear due to the existing
comments on it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 655385)
Time Spent: 2h 20m (was: 2h 10m)
> expose the User ID in the send message tab in console
> -----------------------------------------------------
>
> Key: ARTEMIS-3493
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3493
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Andy Taylor
> Assignee: Andy Taylor
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> this field in the core message is used to keep the JMS Message ID, it would
> be nice to have one auto generated if a checkbox is checked
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
