[ 
https://issues.apache.org/jira/browse/ARTEMIS-3493?focusedWorklogId=654580&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-654580
 ]

ASF GitHub Bot logged work on ARTEMIS-3493:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Sep/21 15:39
            Start Date: 23/Sep/21 15:39
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on pull request #3766:
URL: https://github.com/apache/activemq-artemis/pull/3766#issuecomment-925930422


   For the purpose of this change I would just refer to it as the Message ID 
for the new bits, and have any descriptions/doc note the Message ID in question 
is 'also referred to as UserID in some areas', as opposed to the reverse 
approach it takes now. I think it would be more in line with user expectations 
and be plenty clear from the 'send with message id' context what it all means.
   
   Going beyond that, if you mean for e.g the other table referencing it as 
User ID, I'd also go with swapping it for some variation of Message ID there 
that too if possible, e.g change the format in some way, and also updating the 
other existing 'Message ID' to be referred to as something else (e.g simply ID, 
or Broker Message ID, or perhaps Message Store ID since thats what it seems to 
really represent...could also swap ID with Index). Alternatively if changing 
how that is referenced isnt also possible, then just something long winded like 
Application Message ID would still seem a lot more obvious/intuitive than User 
ID.
   
   If you mean the larger change, then I would go with e.g ID / Broker ID / 
Message Store ID in place of the existing MessageID and deprecate that. 
Something else to replace UserID (e.g MessageID with different format such as 
its capitalization, separator etc). Later remove the old stuff entirely.
   
   I think its also worth saying that any management operations etc that do 
currently take a 'Message ID' currently, i.e the store id, are taking a long. 
If changing things so the application style 'message id' is stored in and 
referenced by something named more like 'message id', I dont think this would 
cause that much confusion since most people are likely used to that being 
another type e.g String, so I dont think it would become particularly unclear 
for e.g manager uses that it changed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 654580)
    Time Spent: 1.5h  (was: 1h 20m)

> expose the User ID in the send message tab in console
> -----------------------------------------------------
>
>                 Key: ARTEMIS-3493
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3493
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Andy Taylor
>            Assignee: Andy Taylor
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> this field in the core message is used to keep the JMS Message ID, it would 
> be nice to have one auto generated if a checkbox is checked



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to