[
https://issues.apache.org/jira/browse/ARTEMIS-3493?focusedWorklogId=654471&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-654471
]
ASF GitHub Bot logged work on ARTEMIS-3493:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/21 11:49
Start Date: 23/Sep/21 11:49
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3766:
URL: https://github.com/apache/activemq-artemis/pull/3766#discussion_r714701995
##########
File path:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/addressSendMessage.js
##########
@@ -87,15 +91,16 @@ var Artemis;
</form>
<p>
- <button type="button" class="btn btn-primary
artemis-send-message-button"
ng-click="$ctrl.message.sendMessage($ctrl.message.durable)">Send
message</button>
+ <button type="button" class="btn btn-primary
artemis-send-message-button"
ng-click="$ctrl.message.sendMessage($ctrl.message.durable,
$ctrl.message.createUserId)">Send message</button>
</p>
<script type="text/ng-template"
id="send-message-instructions.html">
<div>
<p>
This page allows you to send a message to the chosen
address. The message will be of type <code>text</code>
message and it will be possible to add headers to the
message. The sending of the message will be authenticated
using the username and password set ion
<code>preferences</code>, if this is not set then these will
- be null.
+ be null. The <code>durable</code> checkbox makes the
message persistent and the <code>create user Id</code> will auto generate a
+ UUID user for the message which for a JMS Message is the
JMS Message ID.
Review comment:
_"the \<code\>create user Id\</code\> will"_ seems like it should have
_checkbox_ or something else added to complete.
_"a UUID user for"_ seems like it is missing _id_.
##########
File path:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/addressSendMessage.js
##########
@@ -43,6 +43,10 @@ var Artemis;
<label>Durable </label>
<input id="durable" type="checkbox"
ng-model="$ctrl.message.durable" value="true">
</div>
+ <div class="form-group">
+ <label>Create User ID </label>
Review comment:
It isnt really a user supplied id in this case, or any sent with a JMS
client, as its being generated by something else. YEt more reason to reference
the message id it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 654471)
Time Spent: 1h 10m (was: 1h)
> expose the User ID in the send message tab in console
> -----------------------------------------------------
>
> Key: ARTEMIS-3493
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3493
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Andy Taylor
> Assignee: Andy Taylor
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> this field in the core message is used to keep the JMS Message ID, it would
> be nice to have one auto generated if a checkbox is checked
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
