[
https://issues.apache.org/jira/browse/ARTEMIS-4007?focusedWorklogId=810769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-810769
]
ASF GitHub Bot logged work on ARTEMIS-4007:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/22 14:04
Start Date: 21/Sep/22 14:04
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4228:
URL: https://github.com/apache/activemq-artemis/pull/4228#discussion_r976554051
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java:
##########
@@ -521,6 +521,9 @@ public interface ActiveMQServerControl {
@Attribute(desc = "The runtime size of the authorization cache")
long getAuthorizationCacheSize();
+ @Attribute(desc = "The current status of the server")
+ String getStatus();
+
Review Comment:
I dont think 'status' as an attribute is that general, it implies - and
actually outright states for its description here - that it returns the status
of the server, which I wouldnt really say it does in this case.
I think if the value is expected to be in a certain format later it should
adhere to that from the start...this is described on the JIRA and exposed as
being a freeform string set by the config, so 'other things adding keys later'
doenst seem to work / is effectively breaking.
Issue Time Tracking
-------------------
Worklog Id: (was: 810769)
Time Spent: 1.5h (was: 1h 20m)
> properties config - complete feedback loop with server status attribute
> -----------------------------------------------------------------------
>
> Key: ARTEMIS-4007
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4007
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.25.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Following on from ARTEMIS-4001 - in kubernetties - where properties can be
> mounted as projections of config maps, there can be a large delay between
> update and the refresh being visible to the broker.
> Adding a status attribute to the server control that is driven by
> configuration, will allow properties files to embed version or status
> information and see those reflected via admin or jolokia queries.
> This then provides a nice feedback loop. I am calling it status like MetaData
> status, but also leaving it free form such that any sensible json can be
> embedded once there is coordination.
> Initially the value will just be set like any property.
> Eventually it could provide an entry point for the parser to inform of
> property key=value mismatch or errors on update in some "error" section.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
