[ 
https://issues.apache.org/jira/browse/ARTEMIS-4007?focusedWorklogId=810780&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-810780
 ]

ASF GitHub Bot logged work on ARTEMIS-4007:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/22 14:15
            Start Date: 21/Sep/22 14:15
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on code in PR #4228:
URL: https://github.com/apache/activemq-artemis/pull/4228#discussion_r976567244


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java:
##########
@@ -2848,6 +2849,16 @@ public Configuration 
setSuppressSessionNotifications(boolean suppressSessionNoti
       return this;
    }
 
+   @Override
+   public String getStatus() {
+      return status;
+   }
+
+   @Override
+   public void setStatus(String status) {

Review Comment:
   can you add a javadoc here:
   
   Some free string that will define the server's status. a Generic mechanism 
to be set through the configuration?
   
   
   





Issue Time Tracking
-------------------

    Worklog Id:     (was: 810780)
    Time Spent: 1h 40m  (was: 1.5h)

> properties config - complete feedback loop with server status attribute
> -----------------------------------------------------------------------
>
>                 Key: ARTEMIS-4007
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4007
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: 2.25.0
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Following on from ARTEMIS-4001 - in kubernetties - where properties can be 
> mounted as  projections of config maps, there can be a large delay between 
> update and the refresh being visible to the broker.
> Adding a status attribute to the server control that is driven by 
> configuration, will allow properties files to embed version or status 
> information and see those reflected via admin or jolokia queries.
> This then provides a nice feedback loop. I am calling it status like MetaData 
> status, but also leaving it free form such that any sensible json can be 
> embedded once there is coordination.
> Initially the value will just be set like any property.
> Eventually it could provide an entry point for the parser to inform of 
> property key=value mismatch or errors on update in some "error" section. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to